Ticket #908: 49

File 49, 2.4 KB (added by trac, 10 years ago)
Line 
1Source Code Review Form
2=======================
3
4Date:
511th December 2008
6
7Reviewer:
8RH
9
101 Identification
11MaxPendingJobsSLO produces needs for held pending jobs
12IZ#606
13Bugster# 6780497
14ChangeLog# AF-2008-12-11-0:
15
162 Conforms to specification
172.1 [x] yes
182.1 [ ] no
192.1 [ ] n/a - justification:
20
21
223 Documentation
23
243.1 Wiki documentation updated, or Doc Issue filed?
253.1 [x] yes
263.1 [ ] no
273.1 [ ] n/a - justification: Does not apply
28
293.2 man pages (user view) correct?
303.2 [ ] yes
313.2 [ ] no
323.2 [x] n/a - justification: Does not apply
33
343.3 -help output correct and complete?
353.3 [ ] yes
363.3 [ ] no
373.3 [x] n/a - justification: Does not apply
38
393.4 JavaDoc for all public methods correct, updated?
403.4 [x] yes
413.4 [ ] no
423.4 [ ] n/a - justification:
43
443.5 messages, output formats and defines OK?
453.5 [x] yes
463.5 [ ] no
473.5 [ ] n/a - justification:
48
493.6 Bugster CR/MR complete and correct?
503.6 [x] yes
513.6 [ ] no
523.5 [ ] n/a - justification:
53
543.7 Issue Tracker issue complete and correct?
553.7 [x] yes
563.7 [ ] no
573.7 [ ] n/a - justification:
58
59
604 Source review
61
624.1 Considered and documented clean up of resources?
634.1 [x] yes
644.1 [ ] no
654.1 [ ] n/a - justification:
66
674.2 Considered and documented thread safety?
684.2 [x] yes
694.2 [ ] no
70
714.3 Security preserved, user access and file permissions correct?
724.3 [x] yes
734.3 [ ] no
744.3 [ ] n/a - justification:
75
76
775 Tests
78
795.1 Project built successfully?
805.1 [x] yes
815.1 [ ] no - justification:
82
835.2 Existing Junit test already covers issue
845.2 [ ] yes - path:
855.2 [x] no
86
875.3 If 5.2 = no: New JUnit test created?
885.3 [x] yes - path: com.sun.grid.grm.service.impl.ge.slo.MaxPendingsJobsSLOTest#testJobsOnHold606
895.3 [ ] no  - justification:
90
915.4 JUnit tests pass without error
925.4 [x] yes
935.4 [ ] no - justification:
94
955.5 Testsuite test already coveres issue
965.5 [ ] yes - path:
975.5 [x] no
98
995.6 If 5.5 = no: New testsuite test or module test created?
1005.6 [ ] yes - path:
1015.6 [x] no  - justification: No Testsuite tests suggested
102
1035.7 If 5.6 = no: Testsuite issue created?
1045.7 [ ] yes - Issue:
1055.7 [x] no  - justification: see 5.6
106
1075.8 Testsuite run successful
1085.8 [x] yes
1095.8 [ ] no
1105.9 [ ] comment: see 5.6
111
1125.9 Manual tests
1135.9.1 Test description
114
115
1165.9.2 Successful execution
1175.9.2 [x] yes
1185.9.2 [ ] no
1195.9.2 [ ] n/a - justification:
120
1216 Accepted
1226.1 [x] yes
1236.1 [ ] yes with restrictions:
1246.1 [ ] no
125
126
127Comments:
128AF: oneOnOne review with RH
129AF: Fixed minor problems