IZ87: handle_vi_edit for qconf -mhgrp @allhosts reports wrong message on incorrect file

[joga]

[Imported from gridengine issuezilla ​http://gridengine.sunsource.net/issues/show_bug.cgi?id=87]

        Issue #:      87              Platform:     All           Reporter: joga (joga)
       Component:     testsuite          OS:        All
     Subcomponent:    framework       Version:      current          CC:    None defined
        Status:       RESOLVED        Priority:     P3
      Resolution:     FIXED          Issue type:    DEFECT
                                  Target milestone: milestone 1
      Assigned to:    issues@testsuite
      QA Contact:     joga
          URL:
       * Summary:     handle_vi_edit for qconf -mhgrp @allhosts reports wrong message on incorrect file
   Status whiteboard:
      Attachments:

     Issue 87 blocks:
   Votes for issue 87:     Vote for this issue


   Opened: Thu Nov 23 01:23:00 -0700 2006 
------------------------


This was IZ 1970 in project gridengine.

On executing qconf -mhgrp @allhosts  wiht incorrect data, qconf
reports the wrong message back:


starting now!
vi should run now ...
vi terminated! (3)  (rt=1215)
--> vi command: ":%s/^ .*$/  /\n"
--> setting "group_name" to "@allhosts"
--> setting "hostlist" to "dt218-151"
--> setting "cli_stuff" to "dt218-151 dt218-123"
mod_hostgroup returned result of -4 in mod_hostgroup for
            Object has not been changed  for group @allhosts

it should have returned result of -3 for error: unknown attribute name "cli_stuff"


This is done in testuite via handle_vi_edit, so perhaps the problem
may lie in handle_vi_edit rather than qconf.

------- Additional comments from ovid Tue Feb 7 09:34:13 -0800 2006 -------

If a test case passes a new parameter to the CLI tests for a negative test,
this will not fail corretly. procedure build_vi_command assumes that all
the strings passed to it to build a vi command file are of already
existing strings. In the case of new params, the "string substitute"
command fails silently in vi. This then tells handle_vi_edit that
there were only modifications, and the negative test fails.


------- Additional comments from roland Wed Apr 12 01:30:03 -0800 2006 -------

It seems this is a testsuite issue because on command line qconf returns the
expected error message:

"/tmp/rd141302/346-KV00Af" 3 lines, 46 characters
error: unknown attribute name "cli_stuff"
error reading in file

   ------- Additional comments from mpospisil Wed Dec 12 01:40:40 -0700 2007 -------
fixed