IZ89: need test for CR6398008

[joga]

[Imported from gridengine issuezilla ​http://gridengine.sunsource.net/issues/show_bug.cgi?id=89]

        Issue #:      89              Platform:     All           Reporter: joga (joga)
       Component:     testsuite          OS:        All
     Subcomponent:    tests           Version:      current          CC:    None defined
        Status:       RESOLVED        Priority:     P3
      Resolution:     WONTFIX        Issue type:    TASK
                                  Target milestone: milestone 1
      Assigned to:    crei (crei)
      QA Contact:     joga
          URL:
       * Summary:     need test for CR6398008
   Status whiteboard:
      Attachments:

     Issue 89 blocks:
   Votes for issue 89:     Vote for this issue


   Opened: Thu Nov 23 01:29:00 -0700 2006 
------------------------


This was IZ 2001 in project gridengine.

Scenario is described in bug description.

   ------- Additional comments from joga Thu Nov 23 01:31:14 -0700 2006 -------
assigned to crei

   ------- Additional comments from crei Fri Dec 22 06:53:41 -0700 2006 -------
There was a buffer overrun fixed with check-in:

CR-2006-03-14-0: Cleanup:   Off-by-one overrun in communication library
                 Bugtraq:   6398008
                 Review:    RD
                 Changed:   commlib

The problem was that the data_read_buffer_pos length was not checked when
writing a string termination of 0:


+   if ( connection->data_read_buffer_pos >= connection->data_buffer_size) {
+       CL_LOG(CL_LOG_WARNING,"buffer overflow (2)");
+       return CL_RETVAL_STREAM_BUFFER_OVERFLOW;
+   }
+
    connection->data_read_buffer[connection->data_read_buffer_pos] = 0;

This error (off by one overwrite) is not easy to test and will not happen after
the fix.