Opened 7 years ago

Closed 7 years ago

#1365 closed defect

ENOTEMPTY check wrong?

Reported by: Florian.LaRoche@… Owned by:
Priority: normal Milestone:
Component: sge Version: 8.0.0c
Severity: minor Keywords:
Cc:

Description

Hello Dave,

your first change looks like:

if (rmdir(task_spool_dir)) {

if (errno != ENOTEMPTY)

ERROR((SGE_EVENT, MSG_JOB_CANNOT_REMOVE_SS,

MSG_JOB_TASK_SPOOL_FILE, strerror(errno)));

}

Then the next:

if (!rmdir(spool_dir_third)) {

if (ENOTEMPTY == errno)

[...]

if (ENOTEMPTY == errno)

ERROR((SGE_EVENT, MSG_JOB_CANNOT_REMOVE_SS,

MSG_JOB_TASK_SPOOL_FILE, strerror(errno)));

I think you wanted to keep these "ENOTEMPTY != errno" to
check for special other errors here?

best regards,

Florian La Roche

Change History (1)

comment:1 Changed 7 years ago by dlove

  • Status changed from new to closed

I think you wanted to keep these "ENOTEMPTY != errno" to
check for special other errors here?

Right, thanks. I've just pushed the patch that was supposed to be
merged with the first one. I wish I was awake sometimes.

Note: See TracTickets for help on using tickets.