Opened 8 years ago

Closed 8 years ago

#1396 closed defect (fixed)

SGE fixes detected by clangs static analyser

Reported by: o.flebbe@… Owned by:
Priority: normal Milestone:
Component: sge Version: 8.0.0d
Severity: minor Keywords:
Cc:

Description

Hi

Appended you find 3 patch files for bugs detected by clang's static analyser.

I did this with a XCode project created by cmake.

Hope the attachements will go through correctly

Greetings,
Olaf
--
Vorstand/Board? of Management:
Dr. Bernd Finkbeiner, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Philippe Miltin
Sitz/Registered? Office: Tuebingen
Registergericht/Registration? Court: Stuttgart
Registernummer/Commercial? Register No.: HRB 382196

0001-clang-static-ananlyser-detected-duplicate-lines-and-.patch

0002-clang-static-analyser-do-not-divide-by-zero.patch

0003-clang-static-analyser-Do-not-use-path-if-NULL.patch

o_flebbe.vcf

Attachments (5)

0001-clang-static-ananlyser-detected-duplicate-lines-and-.patch (1.1 KB) - added by o.flebbe@… 8 years ago.
Added by email2trac
0002-clang-static-analyser-do-not-divide-by-zero.patch (829 bytes) - added by o.flebbe@… 8 years ago.
Added by email2trac
0003-clang-static-analyser-Do-not-use-path-if-NULL.patch (961 bytes) - added by o.flebbe@… 8 years ago.
Added by email2trac
o_flebbe.vcf (347 bytes) - added by o.flebbe@… 8 years ago.
Added by email2trac
o_flebbe-1.vcf (359 bytes) - added by o.flebbe@… 8 years ago.
Added by email2trac

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by o.flebbe@…

Added by email2trac

Changed 8 years ago by o.flebbe@…

Added by email2trac

Changed 8 years ago by o.flebbe@…

Added by email2trac

Changed 8 years ago by o.flebbe@…

Added by email2trac

comment:5 Changed 8 years ago by dlove

Appended you find 3 patch files for bugs detected by clang's static
analyser.

Thanks. Are all the other ones clang throws up false positives, or are
those the only ones you've verified? I haven't had time to sift them.

I did this with a XCode project created by cmake.

Can you actually build it with clang? It fails for me in several ways
on a GNU/Linux system, which makes it difficult to use clang as a checker.

Hope the attachements will go through correctly

Yes, thanks. I'll install them.

comment:6 Changed 8 years ago by o.flebbe@…

Comment (by dlove):

Appended you find 3 patch files for bugs detected by clang's static
analyser.

Thanks. Are all the other ones clang throws up false positives, or are
those the only ones you've verified? I haven't had time to sift them.

I randomly looked through the reports, some (~5) of them false positives but these are a real. There are ~ 25 left to be looked into. But .. see below:

I did this with a XCode project created by cmake.

Can you actually build it with clang? It fails for me in several ways
on a GNU/Linux system, which makes it difficult to use clang as a checker.

Yes on mac. However CMake does compile and link only a subset of the code: qmaster, qsub for instance. I'll try it on linux with clang ...

Olaf

--
Vorstand/Board? of Management:
Dr. Bernd Finkbeiner, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Philippe Miltin
Sitz/Registered? Office: Tuebingen
Registergericht/Registration? Court: Stuttgart
Registernummer/Commercial? Register No.: HRB 382196

o_flebbe-1.vcf

Changed 8 years ago by o.flebbe@…

Added by email2trac

comment:7 Changed 8 years ago by dlove

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by [4124]

Note: See TracTickets for help on using tickets.