Opened 6 years ago

Closed 6 years ago

#1477 closed defect (fixed)

Prevent SGE_BINDING variable having a spurious space at start

Reported by: markdixon Owned by:
Priority: normal Milestone:
Component: sge Version: 8.1.5
Severity: minor Keywords:
Cc:

Description

Hi Dave,

I've been looking at your cpuset support on Linux where USE_CGROUP=1 and in the process noticed that:

  • Where a job was not allocated cpu 0, the SGE_BINDING string always

starts with a space.

  • SGE_BINDING is subsequently used in shepherd.c's cpusetting() to generate the cpuset binding string. The spurious space is translated into a comma, causing the allocation of cpus to the set to fail.

The attached patch ought to fix the immediate issue, although I wonder if the shepherd should perhaps be interpreting the "binding" string in its configuration file instead.

Cheers,

Mark
--


Mark Dixon Email : m.c.dixon@…
HPC/Grid Systems Support Tel (int): 35429
Information Systems Services Tel (ext): +44(0)113 343 5429
University of Leeds, LS2 9JT, UK


0001-Prevent-SGE_BINDING-variable-having-a-spurious-space.patch

Attachments (1)

0001-Prevent-SGE_BINDING-variable-having-a-spurious-space.patch (1.4 KB) - added by markdixon 6 years ago.
Added by email2trac

Download all attachments as: .zip

Change History (2)

Changed 6 years ago by markdixon

Added by email2trac

comment:1 Changed 6 years ago by dlove

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.