Opened 6 years ago

Closed 6 years ago

Last modified 2 years ago

#1494 closed defect (fixed)

Support building without rpaths

Reported by: opoplawski Owned by: Dave Love <d.love@…>
Priority: normal Milestone:
Component: sge Version: 8.1.6
Severity: minor Keywords:
Cc:

Description

For Fedora packaging we cannot have any rpaths. Please support that. The attached patch is what I currently use to strip them out completely.

Attachments (1)

sge-rpath.patch (1.2 KB) - added by opoplawski 6 years ago.
sge-rpath.patch

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by opoplawski

sge-rpath.patch

comment:2 Changed 6 years ago by dlove

For Fedora packaging we cannot have any rpaths. Please support that. The
attached patch is what I currently use to strip them out completely.

The use for internal shlibs is (or was, when I checked) sanctioned in
the packaging guide, and SGE uses $ORIGIN, not an absolute path.
Removing it will cause trouble for installation in /opt, I think.
However, I think it's at least much less widely required now than it
was. (I don't know whether the dynamically loaded spooling modules can
be avoided.)

Would yet another aimk flag be good enough for you?

comment:3 Changed 6 years ago by opoplawski

Hmm, my bad it seems. I dropped my rpath patch completely and I don't seen any rpaths anymore. So we should be good.

comment:4 Changed 6 years ago by dlove

Hmm, my bad it seems. I dropped my rpath patch completely and I don't
seen any rpaths anymore. So we should be good.

That's odd. rpmlint complains about it for packages built with the spec
file in the source, which I don't think will affect things. I wanted to
avoid distributions having to patch anything long-term, and rpath is
obviously something that should be configurable for that.

By the way, I intended to support both the Fedora file structure and the
traditional /opt-based one in the distributed spec file (perhaps with
the Fedora one the default), controlled by rpmbuild --with. I started
doing that, and someone else offered to work on it, but I haven't heard
back. The rpath should presumably be dependent on that choice.

comment:5 Changed 6 years ago by opoplawski

My double bad - the rpaths are indeed there without the patch. I was relying on some rpm checks rather than rpmlint.

So yes, configurable disabling of rpath is still desired.

comment:6 Changed 6 years ago by Dave Love <d.love@…>

  • Owner set to Dave Love <d.love@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 4725/sge:

Fix #1494: Remove RUNPATH (rpath), using full path to spool lib in bootstrap
Should keep Debian/Fedora? happy.

comment:7 Changed 2 years ago by sidney

This changeset is not in the 8.1.9 release tarball though it is in all of the snapshots that were released since the date this was closed.

comment:8 Changed 2 years ago by sidney

When I tried to include the changeset in an rpm it broke when I the tried to run inst_sge. It looks like the change to source/dist/util/install_modules/inst_qmaster.sh is both broken and unnecessary. It changes $SPOOLING_LIB to $SGE_ROOT_VAL/lib/$ARCH/$SPOOLING_LIB but $SPOOLING_LIB already is an absolute path so that breaks. When I removed that hunk from the changeset everything worked.

Was this breakage the reason that the changeset was not included at all in the 8.1.9 distribution?

Note: See TracTickets for help on using tickets.