Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#1523 closed patch (fixed)

Misdetecting cgroup vs cpuset naming convention

Reported by: wish Owned by: dlove
Priority: normal Milestone:
Component: sge Version: 8.1.8
Severity: minor Keywords:
Cc:

Description

When USE_CGROUPS is enabled the execd can misdetect whether the cpuset controlling filesystem uses the modern cgroup naming convention (cpuset.mems, cpuset.cpus)
or the older cpuset convention (mems,cpus) leading to a failure to correctly initialize the cpuset.

As per this thread:
http://arc.liv.ac.uk/pipermail/sge-discuss/2015-March/000783.html
And this thread:
http://arc.liv.ac.uk/pipermail/sge-discuss/2014-June/000685.html

Attachments (3)

cgroupfix.diff (2.0 KB) - added by wish 4 years ago.
Patch to fix bugs #1523 and #1524
patch-preview.txt (2.0 KB) - added by wish 4 years ago.
Added by email2trac
fix-_1523_type_patch_.dpatch (83.7 KB) - added by wish 4 years ago.
Added by email2trac

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by wish

  • Owner set to wish
  • Status changed from new to accepted

comment:2 Changed 5 years ago by wish

Testing fix

Changed 4 years ago by wish

Patch to fix bugs #1523 and #1524

comment:3 Changed 4 years ago by wish

  • Owner changed from wish to dlove
  • Status changed from accepted to assigned

Patch attached to this ticket. It fixes both this bug and #1524. The fix for #1524 is rather ugly but I was going for minimally intrusive rather than a major rewrite.

Anyway please apply if the ugliness doesn't bother you too much.

comment:5 Changed 4 years ago by wish

  • Type changed from defect to patch

1 patch for repository http://arc.liv.ac.uk/repos/darcs/sge:
Rather than gnu diff
Mon May 4 16:24:42 BST 2015 William Hay <wish@…>

  • fix #1523?type=patch: Submitting via darcs send/trac for ease of application

patch-preview.txt

fix-_1523_type_patch_.dpatch

Changed 4 years ago by wish

Added by email2trac

Changed 4 years ago by wish

Added by email2trac

comment:6 Changed 4 years ago by dlove

  • Resolution set to fixed
  • Status changed from assigned to closed

In 4815/sge:

Fix #1523: Detect old v. new type of cpuset

comment:7 Changed 4 years ago by Dave Love <d.love@…>

In 4852/sge:

Fix #1523: Detect old v. new type of cpuset
Don't abort without cgroups.

Note: See TracTickets for help on using tickets.