Opened 12 months ago

Closed 4 months ago

#1572 closed defect (fixed)

breakages in OpenSSL 1.1.0

Reported by: afif@… Owned by:
Priority: normal Milestone:
Component: sge Version: 8.1.8
Severity: minor Keywords:
Cc:

Description

The next Debian release is expected to have OpenSSL 1.1.

Gridengine fails to build as a result of some of the API changes:
<https://breakpoint.cc/openssl-1.1-rebuild-2016-05-29/Attempted/gridengine_8.1.8%2Bdfsg-6_amd64-20160529-1424>

The Debian bug report is at
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827076>, where you
can find more information. There is a wiki page from OpenSSL describing
what the API changes are:
<https://wiki.openssl.org/index.php/1.1_API_Changes>

--
Afif Elghraoui | عفيف الغراوي
http://afif.ghraoui.name

Attachments (1)

sge_ssl_1.1.patch (7.5 KB) - added by mhy 6 months ago.
Compile tested OpenSSL 1.1 patch

Download all attachments as: .zip

Change History (6)

Changed 6 months ago by mhy

Compile tested OpenSSL 1.1 patch

comment:1 Changed 6 months ago by mhy

Hi,

Attached is a compile-only tested patch for OpenSSL 1.1.

The only changes needed are in source/libs/comm/cl_ssl_framework.c and source/utilbin/sge_passwd.c

The changes are because OpenSSL (as of 1.1) no longer allows allocating structures on the stack, they must be allocated on the heap and the relevant _new and _free routines used to create/destroy them (i.e. all structures are now opaque pointers).

Unfortunately, I don't have an SSL-enabled gridengine cluster to test on, so I'm hoping someone else can help out with this.

The good news is that I have compile tested this against both OpenSSL 1.0 and OpenSSL 1.1 and it compiles against both, so no backwards compatibility code should be needed.

Thanks,

Mark

comment:3 Changed 6 months ago by dlove

Thanks. It wasn't clear to me what would be needed on a quick look some
time ago, as the suggestions for likely changes didn't seem relevant,
and I guessed it would be more of a mess. I'll see if I can test it
sometime, but if someone else can, please do.

comment:4 Changed 4 months ago by dlove

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by [4937]

comment:5 Changed 4 months ago by afif

  • Resolution fixed deleted
  • Status changed from closed to reopened

Charset: utf-8
Version: GnuPG v2

hQELAxyXADrpEqbiAQf4wSlfZjj+HwhIcEkZK/ysoxx7lV5RSssd4hPhfjB/gDmb
GqS31wteGcEaHzfqRlVJRaz9Y/BrpiscoUUNxULaI+sBoKOFwBAHEcRL8athING2
Ee6Y0tMEwJRXjnAQJGuDuUNJJ8JE16sxhjagUnh7CgvSpO+E9XdUGRp7v02wcIp3
JQAhr+S850t3X09UGu3vHQpCDAba4BBLcoVTXCu8Iu0ntsTvBOwLe8QjprlR21
CZM5lcg+wHm/Ye5kTnFLObo/sak2LLpiq2h/Z9EsahrgGXzeOJY3wY5M3ANLjbXh
qeVGS1ETnFnul3figM3h91ayOST5fi4ueEAa3FtFhQIMA3CNbwvLYuAmAQ
UOeI
jM9gieiNi9EXjuM6ThAQ9lt0KPaT6ogf0rwFFJPhkaObaZl2J6PfLYb5ilNHyk9a
20FIdGkMYGMJ6vy6PdfDnyLM+eAKJ+oxEe3OdMrNIrGDzRZzxXQmltrzGGCtqUMD
aDEFb7CCrB3oUnzMdzTPow86IWq1kubB69ABX3JGABn2D80u4hOeZFsW9NWGUs+P
dXGSYhdzxPMWOA960ze3IeZBpzl+upeYuKLYmoejvRr7NdokAsLaTm+zQ/LTugpq
W9BRfuCKEk22aUxC4oP/4YYLAOHN4WIwZyTcAwwMaHtqXLwPMI1thUwIQlOQl2D5
moJp4kMTCMekoApF64zXbXASJOrxb0tohGGBvigNrLwb6CHgqgwC9T8T7CRmvJLB
XPlljFGO0oeHTZmuRfJWEYk1pvHe9DTj7I5pW3GcmOKY+xLcSLBVlbqSwOWHZhBr
KofbUHWYGOrezd5bl7ww3GYiycBH8+Tw2zFPP0ilGTVuOqg/w5fEE0oWVAXt62tL
fNfK23+Qlbbbiheup2ujHWdY1oCiAVUZjuS3gZBAjnSoJwkbxk6cOEsDGj5+BwwR
+d/Rd0KlEwmj9N6VZ7w4bcfGTW6r6rg+NdMsJSaBZoGaiNXa4pPVB4QUeonQjvVU
7uOiyGgYeZB4q8XXRvp+n/PhsAN95JwgoDyxD+bS6QFTQWQvvRAntjOITukfQXn/
b9Xq12Go+nsbIAL9li2LOSt4LMJXXK8OXb3BrkSXESCN2zP9XRwxTYMH+yxOBwmo
hvHbNCxtLL72T1gtahdIt+TZJrOeTV1rI+WkWWRrqtrWI2vnpngjdpzoCLD4x6U5
dfoPRLGBnZdlkQCF2A9nhMAzD4392nOCHFtOQDpa/qiT9BREBAShRRBzn+CsPk76
HYYMBqwdBnJy0yzBnuHO6tm/z5Iz9xsOaaVtkNkVonKr8epRMvsG28UcYlgMfrek
330WfusBQ3jERbjvCZUbll1zfU9PWZ4xaVGFlbXy6rXQttVVyNPYaDYmlap1/woa
FkBEXP5ZdQmqrtP+HgVMGTwP1xIqJJDK4nCeqlksp6/BdpVt0ZCJ3Zh/0WYLGmRp
MQRcXTvNO3wPrrNaF1Y43Wo+AYNf3SdEkmPhyrY/ctqN81ZnA/c34Edm3kZkLsD6
ujrljmeGlXgTXjmDXxAIHDmEao/zEinznAKuIr4weJvfCb3og+yX80Zl+4iHSpBa
1/1aVJo1KJ9UbDyXSUbZl4pvLhnBu4rKV6rORGOtrckBtf5dOOc35qJyx77nbx31
PLmeqQF8aTAC5/oMbVTNcQBLamgDoqvO74TcAOsIEc2ywFiJta0g8DWZ6HowNzUi
xYvhQsonRf5m0/bMFNqaLpByWSrDflJ0xJE+kpwGmqwnxWLceHz2bnKUTpmSRsx2
pze4YxMYyMAJC5m2UjU=
=GimT


comment:6 Changed 4 months ago by afif

  • Resolution set to fixed
  • Status changed from reopened to closed

Sorry about that. My reply to the message I got was improperly (and unnecessarily) encrypted and apparently reopened the ticket.

I just wanted to say that the commit message incorrectly attributed the patch to me when it was in fact provided by Mark Hymers.

I'm sorry about the noise.

Note: See TracTickets for help on using tickets.