Opened 3 years ago

Closed 3 years ago

#1581 closed patch (fixed)

fails to build from source (#endif without #if)

Reported by: afif Owned by: Afif Elghraoui <afif@…>
Priority: normal Milestone:
Component: sge Version: current development
Severity: minor Keywords:
Cc:

Description

I attempted to backport your commit to drop use of union wait[1] to the Debian 8.1.9 package, but it causes the following build error (line numbers are relative to the 8.1.9 version):

../clients/qevent/qevent.c: In function ‘qevent_start_trigger_script’:
../clients/qevent/qevent.c:307:2: error: #endif without #if

#endif


../clients/qevent/Makefile:83: recipe for target 'qevent.o' failed
make[2]: * [qevent.o] Error 1

The attached patch resolves the problem and also streamlines the surrounding ifdefs (otherwise essentially the same condition is being checked three times in a row)

  1. https://gitlab.com/loveshack/sge/commit/538640ffe09a44a14d9f0047708f9c87d90c29ac

Attachments (1)

0001-Remove-extra-endif-and-streamline-surrounding-condit.patch (1.1 KB) - added by afif 3 years ago.

Download all attachments as: .zip

Change History (3)

comment:2 Changed 3 years ago by dlove

Thanks, belatedly. I had to merge that from long ago, but I wonder how
it was broken when it seemed to build before I pushed the change...

comment:3 Changed 3 years ago by Afif Elghraoui <afif@…>

  • Owner set to Afif Elghraoui <afif@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 4907/sge:

Fix #1581: Remove extra #endif and streamline surrounding conditionals

Note: See TracTickets for help on using tickets.