Opened 15 years ago

Closed 7 years ago

Last modified 7 years ago

#215 closed enhancement (fixed)

IZ1383: replace_params() function needs improvement

Reported by: crei Owned by: Dave Love <d.love@…>
Priority: normal Milestone:
Component: sge Version: current
Severity: Keywords: cleanup
Cc:

Description

[Imported from gridengine issuezilla http://gridengine.sunsource.net/issues/show_bug.cgi?id=1383]

        Issue #:      1383             Platform:     All           Reporter: crei (crei)
       Component:     gridengine          OS:        All
     Subcomponent:    cleanup          Version:      current          CC:    None defined
        Status:       NEW              Priority:     P3
      Resolution:                     Issue type:    ENHANCEMENT
                                   Target milestone: ---
      Assigned to:    andreas (andreas)
      QA Contact:     ernst
          URL:
       * Summary:     replace_params() function needs improvement
   Status whiteboard:
      Attachments:

     Issue 1383 blocks:
   Votes for issue 1383:


   Opened: Fri Dec 3 04:41:00 -0700 2004 
------------------------


Fix from CR-2004-12-02-3 is now disabled.

The dst_len parameter is ignored, because fixing
the missing buffer overwrite problem caused
problems in functions calling replace_params().
Every calling function must set the correct buffer
length of dst. This is currently not the case.
Therefore I disabled the buffer overwrite check by
outcommenting the
 *   "&& dp_pos < max_dst_len" part.

A dstring buffer as paramter should fix the problem.

   ------- Additional comments from sgrell Mon Dec 12 02:41:24 -0700 2005 -------
Changed subcomponent.

Stephan

Change History (2)

comment:1 Changed 7 years ago by Dave Love <d.love@…>

  • Owner set to Dave Love <d.love@…>
  • Resolution set to fixed
  • Status changed from new to closed

In [4151/sge]:

(The changeset message doesn't reference this ticket)

comment:2 Changed 7 years ago by Dave Love <d.love@…>

In [4168/sge]:

(The changeset message doesn't reference this ticket)

Note: See TracTickets for help on using tickets.