IZ1457: event master cleanups
|Reported by:||sgrell||Owned by:|
[Imported from gridengine issuezilla http://gridengine.sunsource.net/issues/show_bug.cgi?id=1457]
Issue #: 1457 Platform: All Reporter: sgrell (sgrell) Component: gridengine OS: All Subcomponent: cleanup Version: 6.0 CC: None defined Status: NEW Priority: P2 Resolution: Issue type: DEFECT Target milestone: --- Assigned to: ernst (ernst) QA Contact: ernst URL: * Summary: event master cleanups Status whiteboard: Attachments: Issue 1457 blocks: [DEL: 1675 :DEL] 1675 Votes for issue 1457: Opened: Wed Feb 9 01:29:00 -0700 2005 ------------------------ Hello, we should clean up two things in the event master: - The event master is using its own implemenetation for sub-list filtering. That should be changed to the now available cull sub-list filtering - new events, acks, and event client modifications are stored in three different lists. They should be stored in one. Stephan ------- Additional comments from sgrell Thu Jul 7 05:54:21 -0700 2005 ------- Some additional remarks: - The event client shutdown should be stored in the global list as well. Otherwise the integration of acks and the removing of event clients can get out of sync. This is a nice to have fix since it does not lead to a bug. - When a event client registers itself or modifies it self, the event client structure should be validated to ensure, that it is complete. If the evaluation is not done it, it might crash the qmaster. - A module test should validate the performance of the internal sub-list filitering versus the cull sub-list filtering. If the performance impact is too big, one might to consider to stick with the current custom implementation. ------- Additional comments from sgrell Thu Jul 7 05:57:14 -0700 2005 ------- Ups, I missed another cleanup issue: The current transaction handling is blocking. This needs to change. A minor bug with the resource reservation test showed, that each incomming request has to be garded by a transaction and to take advantage of the two GDI threads, the transaction should be none blocking. Stephan ------- Additional comments from sgrell Thu Jul 7 06:00:03 -0700 2005 ------- And one more: This is an enhancement. While one is add it, it might be a good idea to change the event master to allow internal event clients, meaning event clients which communicate via a hand over list and not the commlib. When that is done. one has also to update the event client and the mirror interface. The mirror interface has be made thread safe, which means that the libs/sgeobj/ module has to be thread safe. Stephan ------- Additional comments from sgrell Thu Jul 7 06:03:37 -0700 2005 ------- Raised priority to p2 because of two bugs depending on this clean up. Stephan ------- Additional comments from sgrell Wed Jul 20 02:49:44 -0700 2005 ------- New cleanups: - 1721 should be taken care of - one should figure out, if job_finished events are realy needed or if they are a duplication of the final_usage_event Stephan
Change History (0)
Note: See TracTickets for help on using tickets.