Opened 10 years ago

Last modified 7 years ago

#434 new defect

IZ2295: sge_exec_job is by far too long and complex

Reported by: joga Owned by:
Priority: high Milestone:
Component: sge Version: current
Severity: Keywords: cleanup
Cc:

Description

[Imported from gridengine issuezilla http://gridengine.sunsource.net/issues/show_bug.cgi?id=2295]

        Issue #:      2295             Platform:     All       Reporter: joga (joga)
       Component:     gridengine          OS:        All
     Subcomponent:    cleanup          Version:      current      CC:    None defined
        Status:       NEW              Priority:     P2
      Resolution:                     Issue type:    DEFECT
                                   Target milestone: ---
      Assigned to:    ernst (ernst)
      QA Contact:     ernst
          URL:
       * Summary:     sge_exec_job is by far too long and complex
   Status whiteboard:
      Attachments:

     Issue 2295 blocks:
   Votes for issue 2295:


   Opened: Fri Jun 15 00:01:00 -0700 2007 
------------------------


The function sge_exec_job has
- some 1500 lines of code,
- 27 returns

It is nearly impossible to track memory usage, when to free memory, control
flow, etc. of this function.

Fixing a bug in this function is really dangerous, esp. when memory
allocation/deallocation is part of the fix.

It shall be split into smaller functional blocks, if possible have one return
statement.

Change History (0)

Note: See TracTickets for help on using tickets.