Opened 11 years ago

Closed 6 years ago

#486 closed defect (fixed)

IZ2482: sge_qquota not processed properly

Reported by: clarinet Owned by: Dave Love <d.love@…>
Priority: normal Milestone:
Component: sge Version: 6.2u5
Severity: minor Keywords: easy fix
Cc:

Description

[Imported from gridengine issuezilla http://gridengine.sunsource.net/issues/show_bug.cgi?id=2482]

        Issue #:      2482             Platform:     PC       Reporter: clarinet (clarinet)
       Component:     gridengine          OS:        Linux
     Subcomponent:    clients          Version:      6.1u3       CC:
                                                                        [_] ernst
                                                                        [_] Remove selected CCs
        Status:       NEW              Priority:     P3
      Resolution:                     Issue type:    DEFECT
                                   Target milestone: ---
      Assigned to:    roland (roland)
      QA Contact:     roland
          URL:
       * Summary:     sge_qquota not processed properly
   Status whiteboard:
      Attachments:

     Issue 2482 blocks:
   Votes for issue 2482:


   Opened: Mon Feb 4 15:28:00 -0700 2008 
------------------------


Parameters in ~/.sge_qquota or system-wide sge_qquota file are not processed
properly, qquota command seems to ignore the first word in the file.

If ~/.sge_qquota contains "-u *", running qquota generates the following
error: 'error: ERROR! invalid option argument "*"'.

If ~/.sge_qquota is empty, running qquota generates the following
error: 'error: ERROR! invalid option argument "pwf"'.

   ------- Additional comments from clarinet Tue Feb 5 03:13:29 -0700 2008 -------
Is not there a problem on line 470 of qquota.c file? Using "++argv" seems fine
for real command line arguments but may fail when processing arguments read
from a file (where there is no argv[0]).

Also, I am not sure if qquota processes duplicate arguments (those that appear
in a file as well as on a command line) correctly.

   ------- Additional comments from andreas Tue Feb 5 03:52:52 -0700 2008 -------
The

   rp = ++argv;

looks strange at all events. With

   rp = argv++;

the code in sge_parse_cmdline_qquota() makes more sense.

Thanks for reporting!

Change History (2)

comment:1 Changed 8 years ago by dlove

  • Keywords easy fix added; PC Linux clients removed
  • Severity set to minor
  • Version changed from 6.1u3 to 6.2u5

Anyone looking at fixing this should probably follow the logic in qstat.

comment:2 Changed 6 years ago by Dave Love <d.love@…>

  • Owner set to Dave Love <d.love@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 4467/sge:

Fix #486: ignore argv[0] only on qquota command line (from Nicolas Joly)

Note: See TracTickets for help on using tickets.