Opened 12 years ago

Closed 8 years ago

#504 closed enhancement (fixed)

IZ2544: qmake should be upgraded to Make 3.80

Reported by: elrond1999 Owned by:
Priority: normal Milestone:
Component: sge Version: 6.1u3
Severity: minor Keywords: clients
Cc:

Description

[Imported from gridengine issuezilla http://gridengine.sunsource.net/issues/show_bug.cgi?id=2544]

        Issue #:      2544             Platform:     All           Reporter: elrond1999 (elrond1999)
       Component:     gridengine          OS:        All
     Subcomponent:    clients          Version:      6.1u3            CC:    None defined
        Status:       NEW              Priority:     P3
      Resolution:                     Issue type:    ENHANCEMENT
                                   Target milestone: ---
      Assigned to:    roland (roland)
      QA Contact:     roland
          URL:
       * Summary:     qmake should be upgraded to Make 3.80
   Status whiteboard:
      Attachments:

     Issue 2544 blocks:
   Votes for issue 2544:


   Opened: Mon Apr 7 01:06:00 -0700 2008 
------------------------


I'm missing the $eval feature in the current qmake version (3.78). It's probably
not to hard to upgrade qmake to 3.8 or later. If this is not possible is it
possible to patch make myself? Do you have a ready patch that I can use somewhere?

   ------- Additional comments from andreas Mon Apr 7 01:38:38 -0700 2008 -------
I'm sorry, but we do not yet have such a patch.

Upgrading qmake to 3.80 or later is certainly possible, but to my knowledge
nobody is working on this right now. If you consider to pursue that I would
suggest to start by obtaining the source diff between 3.78 and 3.80 from the
make source tree. Based on that it might be possible to apply the change as a
patch (using patch(1) command) into SGE source tree.


   ------- Additional comments from rayson Mon Apr 7 21:05:19 -0700 2008 -------
I built qmake with gmake 3.8 a year ago. See:

http://gridengine.sunsource.net/servlets/ReadMsg?list=dev&msgNo=3016

Rayson


   ------- Additional comments from elrond1999 Tue Apr 8 01:10:51 -0700 2008 -------
Hi I tried to do what you said, but I was unable to put any SGE features into
make. It compiles and links with remote-sge.c but the resulting executable does
not understand sge options.. I probably did something wrong along the way :)
Maybe instead I need the 3.78 -> 3.81 make patch. Or the 3.78 ->
3.78-distributed patch.

   ------- Additional comments from rayson Tue Apr 8 05:56:38 -0700 2008 -------
Thanks for trying my changes.

I diff'ed 3.78 qmake vs 3.78 gmake, and I found that I missed one additional
additional in main.c. Without it SGE options are no handled by the new qmake.

int main (int argc, char ** argv)
#endif
{
  ...
  ...
  PATH_VAR (current_directory);

+  /* read and strip options for remote execution */
+  remote_options(&argc, &argv);

#ifdef WINDOWS32

  ...
  ...

Thanks,
Rayson


   ------- Additional comments from rayson Tue Apr 8 06:03:15 -0700 2008 -------
Typo (yup, just woke up a few minutes ago), should be:

"I diff'ed 3.78 qmake vs 3.78 gmake, and found that I missed a change in main.c.
Without it SGE options are not handled by the new qmake."

Also, you will need to add the function declaration:

extern void remote_options PARAMS ((int *p_argc, char **p_argv[]));

BTW, if unsure, you can always download 3.78.1 from GNU, and diff main.c against
the SGE version.

Rayson


   ------- Additional comments from elrond1999 Thu Apr 10 01:08:27 -0700 2008 -------
That did it I now have what seems like a working 3.81 qmake. I had to hack the
Makefile to make it include remote-sge.c/o, so I'm not sure I've done the
./configure correctly but at least it works now.

Change History (1)

comment:1 Changed 8 years ago by dlove

  • Resolution set to fixed
  • Severity set to minor
  • Status changed from new to closed

Fixed by [3990] et seq.

Note: See TracTickets for help on using tickets.