IZ2942: qconf -ke[j] must return non-zero exit code on failure

[mpospisil]

[Imported from gridengine issuezilla ​http://gridengine.sunsource.net/issues/show_bug.cgi?id=2942]

        Issue #:      2942             Platform:     All      Reporter: mpospisil (mpospisil)
       Component:     gridengine          OS:        All
     Subcomponent:    clients          Version:      6.0         CC:    None defined
        Status:       STARTED          Priority:     P3
      Resolution:                     Issue type:    DEFECT
                                   Target milestone: 6.1u7
      Assigned to:    mpospisil (mpospisil)
      QA Contact:     roland
          URL:
       * Summary:     qconf -ke[j] must return non-zero exit code on failure
   Status whiteboard:
      Attachments:

     Issue 2942 blocks:
   Votes for issue 2942:


   Opened: Mon Mar 2 09:44:00 -0700 2009 
------------------------


There is couple of situations, where qconf -ke[j] <host> return zero code, but execd is not shutdown. Displayed message clearly suggests
it's a failure!

This is a problem when users rely on the exit state in their scripts.

I can confirm that in maintrunk this problem exists. I tried the following procedure below with an incorrect exit code.

>qconf -ke host123
failed sending shutdown notification to unknown execd host host123
>echo $?
0

This exit code should definitely not be 0, as this indicates a success when clearly an error occured.

   ------- Additional comments from mpospisil Mon Mar 2 09:48:17 -0700 2009 -------
In the qmaster code, there is no distinction between a failed attempt to kill an execd and a successful attempt. In both cases the status is
marked as STATUS_OK. This needs to be modified to give an error in the case where the attempt failed.