Opened 11 years ago

Last modified 9 years ago

#654 new task

IZ2968: cleanup incosistent definition of RM variable in install script framework

Reported by: crei Owned by:
Priority: low Milestone:
Component: sge Version: 6.2u2
Severity: Keywords: cleanup
Cc:

Description

[Imported from gridengine issuezilla http://gridengine.sunsource.net/issues/show_bug.cgi?id=2968]

        Issue #:      2968             Platform:     All     Reporter: crei (crei)
       Component:     gridengine          OS:        All
     Subcomponent:    cleanup          Version:      6.2u2      CC:    None defined
        Status:       NEW              Priority:     P4
      Resolution:                     Issue type:    TASK
                                   Target milestone: ---
      Assigned to:    ernst (ernst)
      QA Contact:     ernst
          URL:
       * Summary:     cleanup incosistent definition of RM variable in install script framework
   Status whiteboard:
      Attachments:

     Issue 2968 blocks:
   Votes for issue 2968:


   Opened: Tue Mar 31 00:53:00 -0700 2009 
------------------------


A cleanup in the install script framework would be good for the RM (and possible other) variables.
It would be nice to have one file which sets all this global variables.

> grep "RM=" $ALL | egrep "[:| ]RM"
.//inst_qmaster.sh_1.old:                        RM="rm -r"
util//arch_variables:RM=rm
util/install_modules//inst_common.sh:  RM="rm -f"
util/install_modules//inst_qmaster.sh:                        RM="rm -r"
util/install_modules//inst_qmaster_uninst.sh:   RM="rm -fR"
util/sgeCA//sge_ca:RM=rm
util/sgeSMF//sge_smf_support.sh:      RM="rm -f"

And usage looks like:
> grep '$RM' $ALL | grep "-"
util/install_modules//inst_common.sh:          Execute $RM -rf $dir
util/install_modules//inst_common.sh:          ExecuteAsAdmin $RM -rf $dir
util/install_modules//inst_common.sh:            ExecuteAsAdmin $RM -f $SGE_ROOT_VAL/tst$$
util/install_modules//inst_common.sh:            ExecuteAsAdmin $RM -f $SGE_ROOT_VAL/tst$$
util/sgeCA//sge_ca:  Execute $RM -rf $* > /dev/null 2>&1
util/sgeCA//sge_ca:       Execute $RM -rf $i  > /dev/null 2>&1
util/sgeCA//sge_ca:  ExecuteAsAdmin $RM -rf $*  > /dev/null 2>&1
util/sgeCA//sge_ca:       ExecuteAsAdmin $RM -rf $i  > /dev/null 2>&1
util/sgeCA//sge_ca:   $RM -f $RANDFILE
util/sgeCA//sge_ca:   $RM -f $TMPFILE $TMPFILE1
util/sgeCA//sge_ca:   $RM -f $TMPFILE $TMPFILE1
util/sgeCA//sge_ca:   $RM -f $TMPFILE $TMPFILE1
util/sgeCA//sge_ca:            ExecuteAsAdmin $RM -f $OLDCERTFILE
util/sgeCA//sge_ca:   Execute $RM -f $TMPFILE $TMPFILE1

Change History (0)

Note: See TracTickets for help on using tickets.