IZ592: System allows to add services to unmanaged hosts

[afisch]

[Imported from gridengine issuezilla ​http://gridengine.sunsource.net/issues/show_bug.cgi?id=592]

        Issue #:      592          Platform:     Sun         Reporter: afisch (afisch)
       Component:     hedeby          OS:        All
     Subcomponent:    cli          Version:      1.0u1          CC:    None defined
        Status:       NEW          Priority:     P4
      Resolution:                 Issue type:    TASK
                               Target milestone: 1.0u5next
      Assigned to:    adoerr (adoerr)
      QA Contact:     adoerr
          URL:
       * Summary:     System allows to add services to unmanaged hosts
   Status whiteboard:
      Attachments:


     Issue 592 blocks:
   Votes for issue 592:     Vote for this issue


   Opened: Mon Nov 3 10:51:00 -0700 2008 
------------------------


   Description:
   It is allowed to add services (add_ge_service, add_spare_pool_service) to hosts
   that are not part of the current SDM instance:

     sdmadm -s sdmaf ags -h www.sun.com -s test -j cs_vm
     Grid Engine service test added

     sdmadm -s sdmaf asps -h www.sun.com -s test2 -j cs_vm
     service_name hostname    jvm_name message
     -----------------------------------------
     test2        72.5.124.61 cs_vm    ADDED

   Evaluation:
   The problem is rated as p4 task. Adding a service to an unmanaged host is not a
   reasonable action. Furthermore the services on the unmanaged hosts can not be
   started and thus can not interfere with the running SDM instance.


   Suggested fix / work around:
   Fix: The command should be canceled if the service to be added to is not known
   to the system.
   Work around: Remove services added to unmanaged hosts with the remove_service
   command.

   Analysis:
   How to test:
   Write a ts test that tries to add a geadapter / spare pool to an obviously
   unmanaged machine (eg. www.sun.com).

   ETC:
   2.5 PD
               ------- Additional comments from zwierzak Tue Nov 4 05:42:04 -0700 2008 -------
   I have question to suggested fix. What does it mean?? The sentence is not clear :).
   As I assume you meant that we should have some kind of list of inatlled managed
   hosts and when adding new service we should check if host, as in example
   "www.sun.com", is on this list. This managed host list could be stored in
   ConfigurationService as CS has to be running when we add new managed host and CS
   has to be running when we add new service.
               ------- Additional comments from afisch Tue Nov 4 08:14:31 -0700 2008 -------
   thanks Rys, that is what I actually meant. I additionally forgot to add the
   Analysis section

   Analysis:
   The validity of the target host/vm could be checked in a similar way as it is
   done for the remove service command.
   com.sun.grid.grm.ui.component.RemoveServiceCommand.execute()#84-#187. (Of
   special interest is #144-#155.)


               ------- Additional comments from rhierlmeier Wed Nov 25 07:21:10 -0700 2009 -------
   Milestone changed