Opened 50 years ago

Last modified 9 years ago

#899 new task

IZ593: Service is not tested when resource is blacklisted for it.

Reported by: afisch Owned by:
Priority: low Milestone:
Component: hedeby Version: 1.0u1
Severity: Keywords: Sun cli
Cc:

Description

[Imported from gridengine issuezilla http://gridengine.sunsource.net/issues/show_bug.cgi?id=593]

        Issue #:      593          Platform:     Sun         Reporter: afisch (afisch)
       Component:     hedeby          OS:        All
     Subcomponent:    cli          Version:      1.0u1          CC:    None defined
        Status:       NEW          Priority:     P4
      Resolution:                 Issue type:    TASK
                               Target milestone: 1.0u5next
      Assigned to:    adoerr (adoerr)
      QA Contact:     adoerr
          URL:
       * Summary:     Service is not tested when resource is blacklisted for it.
   Status whiteboard:
      Attachments:


     Issue 593 blocks:
   Votes for issue 593:     Vote for this issue


   Opened: Mon Nov 3 11:06:00 -0700 2008 
------------------------


   Description:
   The add_resource_to_blacklist command does not check if the provided service
   name is known to the system:

     ./sdmadm -s sdmaf add_resource_to_blacklist -r some_resource -s spare_poodl
     resource             message
     -----------------------------------------------------------------------
     ents.germany.sun.com The resource was added to the spare_poodl's
     blacklist.

   Evaluation:
   The problem is rated as p4 task. It is not a bug but it is not a reasonable
   action to blacklist a resource for an unknown service. As the service does not
   exist, the blacklist for it is meaningless. However a typo in the service name
   could silently lead to a "white listed" resouce, that should be blacklisted for
   the mistyped service.

   Suggested fix / work around:
   Fix: The service name should be used to check if the service exsists. An
   appropriate error message should be shown in case that it does not.
   Work around: The resource on the blacklist can be normally removed with the
   remove_resource_from_blacklist command.

   Analysis:
   The com.sun.grid.grm.resource.ResourceManager interface should be extended with
   a method to check if a service name is known. Usually an implementation knows
   its services via a ServiceStore that can be explicitly asked. With the new
   method can be checked if the service exist before the resource is blacklisted (
   com.sun.grid.grm.ui.resource.AddResourceIDToBlackListCommand#67).
   !The same code should be implemented for the remove_resource_from_blacklist command!

   How to test:
   A TS test should be written to test if the adding of resources to an unknown
   service's blacklist is possible.

   ETC:
   2 PD
               ------- Additional comments from rhierlmeier Wed Nov 25 07:21:11 -0700 2009 -------
   Milestone changed

Change History (0)

Note: See TracTickets for help on using tickets.