IZ598: remove_bootstrap_config fails with implicit preferences type feature

[afisch]

[Imported from gridengine issuezilla ​http://gridengine.sunsource.net/issues/show_bug.cgi?id=598]

        Issue #:      598          Platform:     Sun         Reporter: afisch (afisch)
       Component:     hedeby          OS:        All
     Subcomponent:    cli          Version:      1.0u1          CC:    None defined
        Status:       NEW          Priority:     P3
      Resolution:                 Issue type:    DEFECT
                               Target milestone: 1.0u5next
      Assigned to:    adoerr (adoerr)
      QA Contact:     adoerr
          URL:
       * Summary:     remove_bootstrap_config fails with implicit preferences type feature
   Status whiteboard:
      Attachments:


     Issue 598 blocks:
   Votes for issue 598:     Vote for this issue


   Opened: Wed Nov 5 09:57:00 -0700 2008 
------------------------


   Description
   If a user mode system is unambiguous and a remove is tried with the rbc command,
   it fails if no pref type is provided and the system is not set to default.

     ./sdmadm -s dummy2 sbc
     WARNING: Host dummyHost is not resolvable
     WARNING: Host dummyHost is not resolvable
     system type host      port properties version
     ---------------------------------------------
     dummy2 USER dummyHost 2    no_ssl     1.0u2

     ./sdmadm -s dummy2 rbc
     WARNING: Host dummyHost is not resolvable
     WARNING: Host dummyHost is not resolvable
     Error: The named system configuration does not exist: dummy2

   Additionally the error message is wrong as is denies the existence of the system.

   Evaluation:
   The issue is rated as p3 defect. A workaround exists. However it might be not to
   obvious from the error message provided.

   Suggested fix:
   The command should be able to auto detect the correct preferences type.
   Work Around:
   The command can be successfully executed by explicitly providing the pref type.



   Analysis:
   The problem lays in the implementation of the
   com.sun.grid.grm.ui.install.RemoveSystemCommand#93-#124
   There is no -p option provided in the command line and the wrapping
   com.sun.grid.grm.cli.cmd.administration.RemoveSystemCliCommand#55 is setting
   pref type to SYSTEM_PROPERTIES. The pref type is set to SYSTEM_PROPERTIES
   (USER,SYSTEM,SYSTEM_PROPERTIES are possible options), what means that it has to
   be evaluated by the system. However it is not resolved afterwards. Thus finally
   the command fails to remove the system as it is not present under system prefs
   (line 116).
   The implicit treatment of the instance as system prefs is rooted in
   com.sun.grid.grm.bootstrap.PreferencesUtil.deleteSystem#72. The method calls
   getBaseNode(prefType) that considers SYSTEM_PROPERTIES as SYSTEM.
   However the issue should be fixed with the resolveSyste routine for 589 once it
   is developed.



   How to test:
   A Test suit test has to be written, that creates a dummy bootstrap config with
   user prefs. Then the remove_bootstrap_config config should be executed as user
   with the above options.


   ETC:
   1.5 PD (considering that 589 is fixed and the resolveSystem routine can be used
   here)
               ------- Additional comments from rhierlmeier Wed Nov 25 07:21:11 -0700 2009 -------
   Milestone changed