IZ697: sdmadm suc does not find newly added service

[rhierlmeier]

[Imported from gridengine issuezilla ​http://gridengine.sunsource.net/issues/show_bug.cgi?id=697]

        Issue #:      697          Platform:     All         Reporter: rhierlmeier (rhierlmeier)
       Component:     hedeby          OS:        All
     Subcomponent:    cli          Version:      10_BETA1       CC:    None defined
        Status:       NEW          Priority:     P3
      Resolution:                 Issue type:    DEFECT
                               Target milestone: 1.0u5next
      Assigned to:    adoerr (adoerr)
      QA Contact:     adoerr
          URL:
       * Summary:     sdmadm suc does not find newly added service
   Status whiteboard:
      Attachments:


     Issue 697 blocks:
   Votes for issue 697:     Vote for this issue


   Opened: Fri Nov 20 07:48:00 -0700 2009 
------------------------


   Description

   If a newly added service is started with

   % sdmadm suc -c <service_name>  (with -h switch)

   The suc command does not find this service/component. However a

   % sdmadm suc -c <service_name> -h <hostname>

   works.

   The issue has only be observed in a non simple installed system.

   Evaluation:

   The issue is a minor impact on the SDM system. Users can always user the -h
   switch.

   Analysis:

   The problem lies in the StartComponentCommand#execute method. The code of this
   method very complex and should be cleaned.

   This method contains three cascaded for loops and it seems that the break in the
   inner for loop is in the wrong scope (line 166).

   A cleanup of this method is strongly recommended.

   Workaround:

   Users must use sdmadm -s <service_name> -h <hostname>.

   How to test

   Add a new spare_pool to the master host of a non simpled installed the system.

   % sdmadm asps -s spare1 -h master_host -j rp_vm

   % sdmadm suc -c spare1

   => command must work.

   For automatic testing we need a Testsuite test.

   ETC: 2PD
               ------- Additional comments from rhierlmeier Fri Nov 20 07:54:05 -0700 2009 -------
   There is a typo in the description. It must be

   % sdmadm suc -c <service_name>  (without -h switch)
                                        ^^^
               ------- Additional comments from rhierlmeier Wed Nov 25 07:21:11 -0700 2009 -------
   Milestone changed