Opened 50 years ago

Last modified 9 years ago

#936 new defect

IZ709: show_blacklist prints name of resource instead of ID

Reported by: zwierzak Owned by:
Priority: normal Milestone:
Component: hedeby Version: 1.0u5_Beta
Severity: Keywords: Sun cli
Cc:

Description

[Imported from gridengine issuezilla http://gridengine.sunsource.net/issues/show_bug.cgi?id=709]

        Issue #:      709          Platform:     Sun              Reporter: zwierzak (zwierzak)
       Component:     hedeby          OS:        All
     Subcomponent:    cli          Version:      1.0u5_Beta          CC:    None defined
        Status:       NEW          Priority:     P3
      Resolution:                 Issue type:    DEFECT
                               Target milestone: not determined
      Assigned to:    adoerr (adoerr)
      QA Contact:     adoerr
          URL:
       * Summary:     show_blacklist prints name of resource instead of ID
   Status whiteboard:
      Attachments:


     Issue 709 blocks:
   Votes for issue 709:     Vote for this issue


   Opened: Mon Dec 7 05:52:00 -0700 2009 
------------------------


   Description:

   sdmadm sb prints name instead of id. If we have more than one resource with the
   same name (different id) managing black lists is nearly impossible.

   -->./sdmadm sb
   service resource
   ---------------------
   sge1    myhost


   # sdmadm sr

   service    id     name          state    type flags usage annotation
   --------------------------------------------------------------------------------
   sge1       res#2  somehost      ASSIGNED host S     50    Got execd update event

   spare_pool res#1  myhost        ASSIGNED host       1
              res#3  myhost        ASSIGNED host       1

   It's impossible using cli to see which resource is blackilisted in service.

   What is more, if we add resource res#3 to a black list (operation succeeds as
   it's different resource) the output for sdmadm sb is event more confusing.

   -->./sdmadm sb
   service resource
   ---------------------
   sge1    myhost

   -->

   There are 2 lines in table but as 2nd line is the same as 1st one (because of
   our table output formatting) the 2nd line is empty.

   Evaluation:

   P3. Administrator has problems just if he has 2 resources with the same name.
   (then he needs to guess which Id is in black list. (I tend even for P2,5)

   Workaround:

   Check logs/ shist for information which resource (ID) is blacklisted. (Not
   really acceptable)

   Fix:

   Print ID instead of name in sdmadm sb command

   Analysis:

   It's pure CLI bug, as blacklists contain the ids of resources. Issue is real
   *one liner*.

   ShowBlackListCliCOmmand.java

   line 91:

    rows.add(new Line(entry.getServiceName(), res.getName(), entry.getError()));

   should be changed to:

    rows.add(new Line(entry.getServiceName(), res.getId().getId(), entry.getError()));


   Do not know if TS test rely on sdmadm sb output (full testsuite run is required
   with fix)

   Test:

   Manually. Check that sdmadm sb prints res#...

   ETC: 1PD

Change History (0)

Note: See TracTickets for help on using tickets.